Skip to content

Rename RequestInterceptor registration methods #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

Rename RequestInterceptor registration methods #950

merged 1 commit into from
Oct 26, 2020
+17 −15

Conversation

@rstoyanchev
Copy link
Contributor

@rstoyanchev rstoyanchev commented Oct 26, 2020

Avoiding the overload with RSocketInterceptor registrations helps to avoid ambiguity when using lambdas.

@rstoyanchev rstoyanchev added this to the 1.x Backlog milestone Oct 26, 2020
@rstoyanchev rstoyanchev self-assigned this Oct 26, 2020
OlegDokuka
OlegDokuka approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@OlegDokuka OlegDokuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rstoyanchev rstoyanchev merged commit e08ff71 into rsocket:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

Assignees

@rstoyanchev rstoyanchev

Labels

task

Projects

None yet

Milestone

1.x Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@rstoyanchev @OlegDokuka